Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Macos Build to different Jobs #4694

Merged
merged 20 commits into from
Apr 12, 2023
Merged

Conversation

luqmanbello
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@luqmanbello luqmanbello requested a review from colin99d April 5, 2023 14:28
@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Apr 5, 2023
@luqmanbello luqmanbello requested a review from jmaslek April 10, 2023 19:11
@jmaslek jmaslek added this pull request to the merge queue Apr 12, 2023
Merged via the queue into develop with commit f1f6dad Apr 12, 2023
@jmaslek jmaslek deleted the feature/improve-macos-CI branch April 12, 2023 13:51
jmaslek added a commit that referenced this pull request Apr 13, 2023
* remove concurrency

* comment int test

* Seperate Macos Build

* Int test check

* crypto

* reduce int test

* Code cleanup

* revert integration test

* Edit the building steps

* papermill

* Fix papermill on both jobs

---------

Co-authored-by: James Maslek <jmaslek11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants