Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix ultima news improvements #4703

Conversation

AdiSai
Copy link
Contributor

@AdiSai AdiSai commented Apr 6, 2023

Description

  • Summary of the change / bug fix.
  • Change the source name from UltimaInsights to Ultima
  • Allow for users to make 25 API calls per day without an API Key
  • Link # issue, if applicable.
    N/A
  • Screenshot of the feature or the bug before/after fix, if applicable.
    Screenshot 2023-04-06 at 1 24 33 PM
  • Relevant motivation and context.
    Ultima Insights team decision
  • List any dependencies that are required for this change.
    N/A

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XL Extra Large feature label Apr 6, 2023
@AdiSai AdiSai changed the base branch from develop to hotfix-news-default-data-source2 April 7, 2023 00:42
@AdiSai AdiSai changed the base branch from hotfix-news-default-data-source2 to develop April 7, 2023 00:43
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@3c86851). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4703   +/-   ##
==========================================
  Coverage           ?   57.71%           
==========================================
  Files              ?      593           
  Lines              ?    54048           
  Branches           ?        0           
==========================================
  Hits               ?    31195           
  Misses             ?    22853           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AdiSai
Copy link
Contributor Author

AdiSai commented Apr 7, 2023

Reflected changes from #4697 @DidierRLopes @jmaslek

Copy link
Collaborator

@DidierRLopes DidierRLopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@DidierRLopes DidierRLopes added this pull request to the merge queue Apr 8, 2023
Merged via the queue into OpenBB-finance:develop with commit bea1086 Apr 8, 2023
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
* WIP - command name refactor + eliminate need for an API key to make < 25 requests per day

* check for no Ultima API Key properly

* test_print_help fixes

* reflect changes from #4697

* re-run test_ultima_newsmonitor_view with --rewrite-expected

* re-run tests without breaking news
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XL Extra Large feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants