-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix ultima news improvements #4703
Hotfix ultima news improvements #4703
Conversation
… 25 requests per day
…nsights/OpenBBTerminal into hotfix-ultima-news-improvements
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4703 +/- ##
==========================================
Coverage ? 57.71%
==========================================
Files ? 593
Lines ? 54048
Branches ? 0
==========================================
Hits ? 31195
Misses ? 22853
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Reflected changes from #4697 @DidierRLopes @jmaslek |
…nsights/OpenBBTerminal into hotfix-ultima-news-improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
* WIP - command name refactor + eliminate need for an API key to make < 25 requests per day * check for no Ultima API Key properly * test_print_help fixes * reflect changes from #4697 * re-run test_ultima_newsmonitor_view with --rewrite-expected * re-run tests without breaking news
Description
N/A
Ultima Insights team decision
N/A
How has this been tested?
Checklist:
feature/feature-name
orhotfix/hotfix-name
.Others