Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/ TA multi handle no params + with params #4706

Merged
merged 12 commits into from
Apr 7, 2023

Conversation

tehcoderer
Copy link
Contributor

Before

/ta/multi --indicators macd,obv,sma[50,150]
image

After

image

@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 7, 2023
@reviewpad reviewpad bot added feat XL Extra Large feature and removed feat XS Extra small feature labels Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@1d65fba). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4706   +/-   ##
==========================================
  Coverage           ?   57.72%           
==========================================
  Files              ?      593           
  Lines              ?    54048           
  Branches           ?        0           
==========================================
  Hits               ?    31197           
  Misses             ?    22851           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@andrewkenreich andrewkenreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix

@tehcoderer tehcoderer added this pull request to the merge queue Apr 7, 2023
Merged via the queue into OpenBB-finance:develop with commit 6abf1f5 Apr 7, 2023
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
* fix ta multi when giving params to 1 and not others

* tests

* idk

* fix reset axes

* Update main.js

* idk2

* Update helper_funcs.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XL Extra Large feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants