Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source.md #4723

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Update source.md #4723

merged 2 commits into from
Apr 10, 2023

Conversation

the-praxs
Copy link
Contributor

Fixed Windows path in cleanup_artifacts script portion.

Description

  • Modified the path in Windows cleanup_artifacts script section to reflect Windows directory style.
  • Consistency.
  • No dependency change.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

Fixed Windows path in cleanup_artifacts script portion.
@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 10, 2023
@hjoaquim hjoaquim requested a review from piiq April 10, 2023 10:40
@andrewkenreich
Copy link
Contributor

this is good, I was going to update this today as well after I ran through the steps this weekend

@andrewkenreich andrewkenreich self-requested a review April 10, 2023 13:25
Copy link
Contributor

@andrewkenreich andrewkenreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works for windows - i had to do this

@andrewkenreich andrewkenreich added this pull request to the merge queue Apr 10, 2023
Merged via the queue into OpenBB-finance:develop with commit b06c050 Apr 10, 2023
@the-praxs the-praxs deleted the patch-1 branch April 12, 2023 12:28
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
Fixed Windows path in cleanup_artifacts script portion.

Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants