Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change installation from pip to poetry #4731

Merged
merged 41 commits into from
Apr 12, 2023
Merged

Change installation from pip to poetry #4731

merged 41 commits into from
Apr 12, 2023

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Apr 10, 2023

On the nightly build, we get the following irritating warning:

requests/__init__.py:109: RequestsDependencyWarning: urllib3 (1.26.11) or chardet (None)/charset_normalizer (3.1.0) doesn't match a supported version!

This ideally gets rid of that.

@jmaslek jmaslek added the build Build-related work label Apr 10, 2023
@jmaslek jmaslek requested a review from andrewkenreich April 10, 2023 17:46
@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 10, 2023
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat XS Extra small feature labels Apr 12, 2023
@reviewpad reviewpad bot added feat XS Extra small feature and removed feat S Small T-Shirt size Feature labels Apr 12, 2023
Copy link
Contributor

@andrewkenreich andrewkenreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdf

reviewpad[bot]
reviewpad bot previously requested changes Apr 12, 2023
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

@jmaslek jmaslek enabled auto-merge April 12, 2023 14:17
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@f1f6dad). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4731   +/-   ##
==========================================
  Coverage           ?   57.51%           
==========================================
  Files              ?      588           
  Lines              ?    53794           
  Branches           ?        0           
==========================================
  Hits               ?    30942           
  Misses             ?    22852           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek jmaslek added this pull request to the merge queue Apr 12, 2023
Merged via the queue into develop with commit 2238913 Apr 12, 2023
jmaslek added a commit that referenced this pull request Apr 13, 2023
* Change installation from pip to poetry

* Change env name to obb

* Change shell for mac build

* Activate the env

* Shell again

* Shell from bash to bash -l {0}

* windows poetry

* fix

* provactive fix

* fix

* venv

* removing pathex

* artifact to v2.2.4

* v3

* zip and unzip test

* fuzz fix

* numpy stupid

* asdf

* cmd line

* forgot to activate

* asdf

* asdf

* i dunno anymore

* back to old faithful

* fix spec

* fixing zip maybe

* path fix

* fix path

* code cleanup

* change artifact back

* test new nsis info

* didnt like my version

* add start program to end of install

* adding launch button to installer

* testing version file

* Copy over mac os

* poetry

* reqs

---------

Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com>
Co-authored-by: luqazino@gmail.com <luqazino@gmail.com>
@luqmanbello luqmanbello deleted the hotfix/package branch April 19, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build-related work feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants