Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default routines available & download personal routines on login #4737

Merged
merged 29 commits into from
Apr 13, 2023

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Apr 11, 2023

Description

  • Fixed exe command not allowing routines with spaces in file name
  • Downloads and overwrites default routines from https://tffo1zc1.directus.app/items/Routines on login
  • Downloads and overwrites personal routines on login (limited to 100 routines), this runs silently in a separate daemon thread to avoid stalling the user on login if download takes more than expected
  • Deletes account_model.py and moves functions to routines_handler.py
  • Adds "Version" and "Last update" columns to account/list command

image

Screenshot 2023-04-12 at 15 59 12

@montezdesousa montezdesousa added the account Authentication features label Apr 11, 2023
@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Apr 11, 2023
@montezdesousa montezdesousa marked this pull request as draft April 11, 2023 14:13
@reviewpad reviewpad bot added feat M Medium T-Shirt size feature and removed feat S Small T-Shirt size Feature labels Apr 11, 2023
@montezdesousa montezdesousa marked this pull request as ready for review April 12, 2023 14:45
@montezdesousa montezdesousa requested a review from JerBouma April 12, 2023 14:45
@montezdesousa montezdesousa changed the title Make default routines available Make default routines available & download personal routines on login Apr 12, 2023
@montezdesousa montezdesousa requested a review from jmaslek April 12, 2023 14:54
@JerBouma
Copy link
Contributor

Something is off, it doesn't recognize my FRED key.


(🦋) / $ exe --file The Influence of the Central Bank.openbb



(🦋) /fixedincome/ $ ecb --export CentralBanks.xlsx --sheet-name ECB Rates

API_FRED_KEY not defined. Set the API key under keys menu.

(🦋) /fixedincome/ $ fed --export CentralBanks.xlsx --sheet-name FED Rates

API_FRED_KEY not defined. Set the API key under keys menu.

(🦋) /fixedincome/ $ projection --export CentralBanks.xlsx --sheet-name FED Projections

API_FRED_KEY not defined. Set the API key under keys menu.




(🦋) /economy/ $ ccpi --countries european_union_27 --start 2000-01-01 --export CentralBanks.xlsx --sheet-name CPI EU

Saved file: /Users/jeroenbouma/OpenBBUserData/exports/CentralBanks.xlsx

(🦋) /economy/ $ cpi --start 2000-01-01 --export CentralBanks.xlsx --sheet-name CPI US

API_FRED_KEY not defined. Set the API key under keys menu.

(🦋) /fixedincome/ $ treasury --long united_states,euro_area --export CentralBanks.xlsx --sheet-name Government Yields

Saved file: /Users/jeroenbouma/OpenBBUserData/exports/CentralBanks.xlsx

@montezdesousa
Copy link
Contributor Author

montezdesousa commented Apr 12, 2023

Something is off, it doesn't recognize my FRED key.


(🦋) / $ exe --file The Influence of the Central Bank.openbb



(🦋) /fixedincome/ $ ecb --export CentralBanks.xlsx --sheet-name ECB Rates

API_FRED_KEY not defined. Set the API key under keys menu.

(🦋) /fixedincome/ $ fed --export CentralBanks.xlsx --sheet-name FED Rates

API_FRED_KEY not defined. Set the API key under keys menu.

(🦋) /fixedincome/ $ projection --export CentralBanks.xlsx --sheet-name FED Projections

API_FRED_KEY not defined. Set the API key under keys menu.




(🦋) /economy/ $ ccpi --countries european_union_27 --start 2000-01-01 --export CentralBanks.xlsx --sheet-name CPI EU

Saved file: /Users/jeroenbouma/OpenBBUserData/exports/CentralBanks.xlsx

(🦋) /economy/ $ cpi --start 2000-01-01 --export CentralBanks.xlsx --sheet-name CPI US

API_FRED_KEY not defined. Set the API key under keys menu.

(🦋) /fixedincome/ $ treasury --long united_states,euro_area --export CentralBanks.xlsx --sheet-name Government Yields

Saved file: /Users/jeroenbouma/OpenBBUserData/exports/CentralBanks.xlsx

Seems to work here. Does it work if you run those commands manually? Is the key defined in the keys menu?

@JerBouma
Copy link
Contributor

Ahh this is on my end, it's because if you log-in I "lose" all API keys. Need to import env.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@b03ac8b). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4737   +/-   ##
==========================================
  Coverage           ?   58.11%           
==========================================
  Files              ?      584           
  Lines              ?    53813           
  Branches           ?        0           
==========================================
  Hits               ?    31276           
  Misses             ?    22537           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek
Copy link
Collaborator

jmaslek commented Apr 13, 2023

Works on my end. Gonna merge this for release

Screenshot 2023-04-13 at 8 41 14 AM

@jmaslek jmaslek added this pull request to the merge queue Apr 13, 2023
Merged via the queue into develop with commit 7d3172a Apr 13, 2023
@piiq piiq deleted the feature/default_routines branch April 24, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account Authentication features feat M Medium T-Shirt size feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants