Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL(404) fixes for multiple locations #4738

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Conversation

martinb-ai
Copy link
Contributor

Fixes URLs

@martinb-ai martinb-ai added the bug Fix bug label Apr 11, 2023
@martinb-ai martinb-ai self-assigned this Apr 11, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 11, 2023
Copy link
Contributor

@andrewkenreich andrewkenreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workinggg

@martinb-ai martinb-ai enabled auto-merge April 11, 2023 18:06
@martinb-ai martinb-ai added this pull request to the merge queue Apr 11, 2023
@@ -11,7 +11,7 @@ The FA module provides programmatic access to the commands from within the OpenB
- Financial Modeling Prep
- Polygon

View [this page](https://docs.openbb.co/terminal/quickstart/api-keys) for a list of all API sources used across the platform.
View [this page](https://docs.openbb.co/terminal/usage/guides/api-keys) for a list of all API sources used across the platform.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should point to hub

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are the URLS?


Do note that it is also possible that the menu or command has been deprecated. If this is oversight, please reach out to us [here](https://openbb.co/support).

</details>

<details><summary>Charts do not display on Linux/WSL or Docker installation.</summary>

Check that X-11, or similar, is installed, open, and configured. Follow the instructions pertaining to the system here: [https://docs.openbb.co/terminal/quickstart/installation#3-configuring-your-x-server-to-show-plots](https://docs.openbb.co/terminal/quickstart/installation#3-configuring-your-x-server-to-show-plots)
Check that X-11, or similar, is installed, open, and configured. Follow the instructions pertaining to the system here: [https://docs.openbb.co/terminal/installation/docker](https://docs.openbb.co/terminal/installation/docker)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also point to hub

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are urls?

Merged via the queue into develop with commit 8397a99 Apr 11, 2023
@martinb-ai
Copy link
Contributor Author

@jose-donato this was auto merged. I will make a quick PR for the new URLS when you can provide me with them.

jmaslek pushed a commit that referenced this pull request Apr 13, 2023
@piiq piiq deleted the hotfix/fix-url-404 branch April 24, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants