Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Polygon API key authentication URL #4748

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Fixed Polygon API key authentication URL #4748

merged 4 commits into from
Apr 12, 2023

Conversation

the-praxs
Copy link
Contributor

@the-praxs the-praxs commented Apr 12, 2023

Description

How has this been tested?

Checking multiple keys using the command keys\polygon -k <API_KEY>

  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 12, 2023
@the-praxs
Copy link
Contributor Author

@hjoaquim please tell me where the Linting test is failing.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@2e79308). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4748   +/-   ##
==========================================
  Coverage           ?   57.51%           
==========================================
  Files              ?      588           
  Lines              ?    53794           
  Branches           ?        0           
==========================================
  Hits               ?    30942           
  Misses             ?    22852           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@colin99d
Copy link
Contributor

@hjoaquim please tell me where the Linting test is failing.

openbb_terminal/keys_model.py:6:1: I001 [*] Import block is un-sorted or un-formatted
Looks like we just need to sort the imports. To fix this run the following:

  1. pip install ruff
  2. ruff . --fix

Thank you for this PR!

@the-praxs
Copy link
Contributor Author

@colin99d thank you for the info! Fixed and committed.

@colin99d colin99d self-requested a review April 12, 2023 13:25
@colin99d
Copy link
Contributor

Screenshot 2023-04-12 at 9 25 35 AM

This works for me!

@colin99d colin99d added this pull request to the merge queue Apr 12, 2023
Merged via the queue into OpenBB-finance:develop with commit 6fa4162 Apr 12, 2023
@the-praxs the-praxs deleted the hotfix/4747 branch April 12, 2023 16:20
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
* Fixed Polygon API key check URL

* Bifurcated request URL into 2 lines

* Fixed import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Polygon API key test failed for Basic plan keys
2 participants