Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub | Fallback to .env + don't upload keys + update support link #4756

Merged
merged 9 commits into from
Apr 13, 2023

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Apr 12, 2023

Description

  • Fallback to .env if keys not in hub
  • Display correct source (.env(s), hub) hierarchy for keys
  • Keys changed in the terminal are only written in the .env
  • Point login prompt support link to https://my.openbb.dev/app/terminal/support

@montezdesousa montezdesousa added the account Authentication features label Apr 12, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 12, 2023
@montezdesousa montezdesousa marked this pull request as ready for review April 12, 2023 17:06
@montezdesousa montezdesousa requested a review from jmaslek April 12, 2023 17:45
@montezdesousa montezdesousa changed the title Hub | Fallback to .env + don't upload keys Hub | Fallback to .env + don't upload keys + update support link Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@495beee). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4756   +/-   ##
==========================================
  Coverage           ?   57.45%           
==========================================
  Files              ?      586           
  Lines              ?    53741           
  Branches           ?        0           
==========================================
  Hits               ?    30878           
  Misses             ?    22863           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek
Copy link
Collaborator

jmaslek commented Apr 13, 2023

Niceeee
Screenshot 2023-04-13 at 8 39 19 AM

@jmaslek jmaslek added this pull request to the merge queue Apr 13, 2023
Merged via the queue into develop with commit f0b5cc0 Apr 13, 2023
@montezdesousa montezdesousa deleted the hotfix/fallback_env branch April 13, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account Authentication features feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants