Fix exe --file choices on login
#4799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montezdesousa
changed the title
exe --file autocompleteexe --file choices on login
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4799 +/- ##
==========================================
Coverage ? 58.41%
==========================================
Files ? 586
Lines ? 53754
Branches ? 0
==========================================
Hits ? 31400
Misses ? 22354
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Can you merge this with the other PR, #4802? Hard to test the other without this in place. :) |
done |
jmaslek
added a commit
that referenced
this pull request
Apr 17, 2023
* add remember attribute to user * don't save hist if not remember * remove routines on exit if not remember * fix unittests * remove hub routines on exit * check if user is local first * remove hist file on exit if not remember * comma * Fix `exe --file` choices on login (#4799) * download and save routines in sync, to have choices immediatly available * fix: docs min --------- Co-authored-by: jose-donato <zmcdonato@gmail.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> --------- Co-authored-by: jose-donato <zmcdonato@gmail.com> Co-authored-by: James Maslek <jmaslek11@gmail.com>
montezdesousa
added a commit
that referenced
this pull request
Apr 17, 2023
* add remember attribute to user * don't save hist if not remember * remove routines on exit if not remember * fix unittests * remove hub routines on exit * check if user is local first * remove hist file on exit if not remember * comma * Fix `exe --file` choices on login (#4799) * download and save routines in sync, to have choices immediatly available * fix: docs min --------- Co-authored-by: jose-donato <zmcdonato@gmail.com> Co-authored-by: James Maslek <jmaslek11@gmail.com> * don't delete session on reset * Update terminal_helper.py * Update terminal_helper.py * less prints --------- Co-authored-by: jose-donato <zmcdonato@gmail.com> Co-authored-by: James Maslek <jmaslek11@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exe --filechoices are updated right after loginTest:
openbb --loginandaccount/loginand check thatexe --filecommand onhomemenu displays the hub routines (default and personal)