-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added exchange
filter in stocks\search
#4801
Conversation
@jmaslek can you help me with the failed tests? |
Yessir. Needed to pass another argument to the expected kwarg |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4801 +/- ##
==========================================
Coverage ? 58.44%
==========================================
Files ? 588
Lines ? 53607
Branches ? 0
==========================================
Hits ? 31328
Misses ? 22279
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
I should learn to modify the tests too. Thanks for the help! |
Description
stocks/search --exchange
Filter does not work. #4778exchange
to theexchange_country
argument and-e
to-ec
exchange
filter that can search based on the exchange name e.g. NYS, FRA etccall_search
instocks_helper.py
by adding info aboutexchange
andindustry_group
argumentsHow has this been tested?
Tested using various command argument combinations on the terminal and via SDK.
Checklist:
feature/feature-name
orhotfix/hotfix-name
.Others