Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exchange filter in stocks\search #4801

Merged
merged 7 commits into from
Apr 19, 2023
Merged

Added exchange filter in stocks\search #4801

merged 7 commits into from
Apr 19, 2023

Conversation

the-praxs
Copy link
Contributor

Description

  • Modified the argument exchange to the exchange_country argument and -e to -ec
  • Added the new exchange filter that can search based on the exchange name e.g. NYS, FRA etc
  • Fixed docstring for call_search in stocks_helper.py by adding info about exchange and industry_group arguments

How has this been tested?

Tested using various command argument combinations on the terminal and via SDK.

  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 17, 2023
@the-praxs
Copy link
Contributor Author

@jmaslek can you help me with the failed tests?

@jmaslek
Copy link
Collaborator

jmaslek commented Apr 19, 2023

@jmaslek can you help me with the failed tests?

Yessir. Needed to pass another argument to the expected kwarg

@jmaslek jmaslek enabled auto-merge April 19, 2023 14:07
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@e27a40a). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4801   +/-   ##
==========================================
  Coverage           ?   58.44%           
==========================================
  Files              ?      588           
  Lines              ?    53607           
  Branches           ?        0           
==========================================
  Hits               ?    31328           
  Misses             ?    22279           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@the-praxs
Copy link
Contributor Author

I should learn to modify the tests too. Thanks for the help!

@jmaslek jmaslek added this pull request to the merge queue Apr 19, 2023
Merged via the queue into OpenBB-finance:develop with commit df5d5a0 Apr 19, 2023
@the-praxs the-praxs deleted the hotfix/4778 branch April 20, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stocks/search --exchange Filter does not work.
2 participants