Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Terminal Basics Guide for 3.0. #4835

Merged
merged 47 commits into from
Apr 25, 2023
Merged

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented Apr 20, 2023

Description

This PR updates the Terminal basics guide for version 3.0. It includes new details for working with the charts and tables.

Also updated in this PR is:

  • Terminal Forecast Introduction
  • Technical Analysis Intro
  • Terminal Customization Guide

@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Apr 20, 2023
@reviewpad reviewpad bot added feat M Medium T-Shirt size feature and removed feat S Small T-Shirt size Feature labels Apr 20, 2023
@deeleeramone deeleeramone marked this pull request as ready for review April 20, 2023 03:29
@deeleeramone deeleeramone requested a review from JerBouma April 20, 2023 03:29
@deeleeramone deeleeramone added docs Code documentation guides Guides and online documentation labels Apr 20, 2023
Comment on lines 129 to 148
### Light and Dark Mode

Let's change the starting and ending period of the data that is being loaded in by doing the following:
Set the theme, globally, as either light or dark.

Dark mode:

```console
/settings/chart -s dark
```
(🦋) /stocks/ $ load AMZN -s 2005-01-01 -e 2010-01-01

Loading Daily data for AMZN with starting period 2005-01-03.
Light mode:

```console
/settings/chart -s light
```

We can check that this period has changed by looking into the <a href="https://www.investopedia.com/trading/candlestick-charting-what-is-it/" target="_blank" rel="noreferrer noopener">candle chart</a> with `candle`. This, again shares the same `-h` argument. This results in the following which indeed depicts our selected period.
The default state is dark mode.

```console
/stocks/load aapl -w/candle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would drop this because we can change it in the chart itself and changing a theme color isnt important enough in my mind to warrant being on the basics page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sections on chart/table theme commands removed.

@reviewpad reviewpad bot added feat L Large T-Shirt size Feature and removed feat M Medium T-Shirt size feature labels Apr 21, 2023
@deeleeramone deeleeramone changed the title Updates Terminal Basics Guide for 3.0. Images to follow. Updates Terminal Basics Guide for 3.0. Apr 21, 2023
Comment on lines 25 to -37

:::note **About Pipelines**
You can quickly jump between menus by using a forward slash (`/`). For example, if I want to access the options menu, You can type `/stocks/options` to instantly arrive at this menu. You can do this from any location within the OpenBB Terminal!
:::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should definitely still be incorporated here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is included near the top:
Screenshot 2023-04-21 at 11 57 01 AM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like on the website how it is visualized as a special box. Maybe we can keep the box and start it from the sentence you have as "Absolute path are also valid" ?


To draw on the chart, select one of the four drawing buttons and drag the mouse over the desired area. Click on any existing shape to modify it by dragging with the mouse and editing the color, or remove it by clicking the toolbar button, `Erase Active Shape`. The edit colors button will pop up as a floating icon, and clicking on that will display the color palette.

![Edit Colors](https://user-images.githubusercontent.com/85772166/233248349-d7cd2e2e-7e22-4efb-acdb-5f7a85bf2932.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is the default stuff, but this is very hard to read on the chart. NOt sure if you can change either to a light theme chart or a lighter font color

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated charts, much easier it to read now.

```

![Candlestick Chart Amazon](https://user-images.githubusercontent.com/46355364/223211728-1317abea-36da-461c-bc3b-140ed7973173.svg)
![Selecting a new Data Source](https://user-images.githubusercontent.com/85772166/233719604-9f28b80d-4c5f-41f5-8cfe-71d5aaa6da99.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this image in unnecessary. I was envisioning an example of how to set, so something like

set --cmd stocks/fa/income --source FinancialModelingPrep

But maybe a close zoom in of the function showing --source does also make sense to show.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I was making an example of a preference being overridden and not set with the /sources menu.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to just be a zoomed shot of the source choices.

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch coverage: 43.15% and project coverage change: -0.15 ⚠️

Comparison is base (a1aff50) 58.43% compared to head (9a564d9) 58.29%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4835      +/-   ##
===========================================
- Coverage    58.43%   58.29%   -0.15%     
===========================================
  Files          588      588              
  Lines        53608    53659      +51     
===========================================
- Hits         31328    31280      -48     
- Misses       22280    22379      +99     
Impacted Files Coverage Δ
generate_sdk.py 90.82% <ø> (ø)
openbb_terminal/account/account_controller.py 81.02% <0.00%> (-1.78%) ⬇️
...mmon/technical_analysis/custom_indicators_model.py 20.83% <0.00%> (ø)
...minal/common/technical_analysis/volatility_view.py 32.81% <ø> (ø)
...lots/plotly_ta/plugins/custom_indicators_plugin.py 14.13% <0.00%> (ø)
openbb_terminal/core/sdk/sdk_init.py 92.75% <ø> (ø)
openbb_terminal/core/session/routines_handler.py 63.52% <0.00%> (-20.02%) ⬇️
...b_terminal/econometrics/econometrics_controller.py 47.40% <ø> (ø)
openbb_terminal/featflags_controller.py 84.81% <ø> (-3.15%) ⬇️
openbb_terminal/forecast/forecast_controller.py 1.12% <0.00%> (ø)
... and 27 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek jmaslek enabled auto-merge April 25, 2023 16:15
@jmaslek jmaslek added this pull request to the merge queue Apr 25, 2023
Merged via the queue into develop with commit 4dce2fa Apr 25, 2023
@jmaslek jmaslek deleted the hotfix/docs_terminal_basics_3p0 branch May 1, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Code documentation feat L Large T-Shirt size Feature guides Guides and online documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants