Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stocks/ta/fib datetime plotting #4875

Merged

Conversation

clairericks
Copy link
Contributor

@clairericks clairericks commented Apr 24, 2023

Description

Fixes #4862.

Updates data.index.get_loc to data.index.get_indexer. Converts datetime object to pandas datetime object before calling to_pydatetime in fib plotting.

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 24, 2023
@clairericks clairericks marked this pull request as ready for review April 24, 2023 11:35
Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Screenshot 2023-04-24 at 8 43 41 AM

@jmaslek jmaslek added this pull request to the merge queue Apr 24, 2023
Merged via the queue into OpenBB-finance:develop with commit fc66bd7 Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] stocks/ta/fib - Error plotting fib: 'datetime.datetime' object has no attribute 'to_pydatetime'
2 participants