Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update installation docs for release #4876

Merged
merged 8 commits into from
Apr 24, 2023
Merged

Update installation docs for release #4876

merged 8 commits into from
Apr 24, 2023

Conversation

piiq
Copy link
Contributor

@piiq piiq commented Apr 24, 2023 •
edited
Loading

  • Point download links for environment and docker artifacts to main instead of a blob
  • Clean-up debug echo in macos launcher script

@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 24, 2023
@piiq piiq added docs Code documentation and removed feat XS Extra small feature labels Apr 24, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 24, 2023
@piiq piiq marked this pull request as ready for review April 24, 2023 14:56
@piiq piiq requested a review from deeleeramone April 24, 2023 14:56
@jmaslek
Copy link
Collaborator

jmaslek commented Apr 24, 2023

I cant build locally:

Module build failed (from ./node_modules/@docusaurus/mdx-loader/lib/index.js):
SyntaxError: /Users/james/OpenBBTerminal/OpenBBTerminal/website/content/terminal/installation/macos.md: Expected corresponding JSX closing tag for <img>. (48:0)

@deeleeramone
Copy link
Contributor

Also cannot build locally.

Screenshot 2023-04-24 at 9 49 39 AM

@piiq
Copy link
Contributor Author

piiq commented Apr 24, 2023

Fixed, github web editor likes a different flavour of markdown

@deeleeramone
Copy link
Contributor

Do we update the download links now? Is there a way to make this more robust so that it doesn't need to be updated manually every release?

@piiq
Copy link
Contributor Author

piiq commented Apr 24, 2023

Do we update the download links now?

No, James does this as a part of the release routine in the release branch

Is there a way to make this more robust so that it doesn't need to be updated manually every release?

This question is outside of the scope of this PR

deeleeramone
deeleeramone approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@deeleeramone deeleeramone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jmaslek jmaslek added this pull request to the merge queue Apr 24, 2023
Merged via the queue into develop with commit 80dabc1 Apr 24, 2023
@piiq piiq deleted the hotfix/install3_docs branch April 24, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deeleeramone deeleeramone deeleeramone approved these changes

Assignees
No one assigned
Labels
docs Code documentation feat XS Extra small feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piiq @jmaslek @deeleeramone