Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last minutes enhancements #4885

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Last minutes enhancements #4885

merged 4 commits into from
Apr 24, 2023

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Apr 24, 2023

  • Remove featflag/tab
  • Fix featflag/overwrite not overwriting
  • Change fundamentals exporting to do transpose

@jmaslek jmaslek added the enhancement Enhancement label Apr 24, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 34.21% and project coverage change: -0.16 ⚠️

Comparison is base (a1aff50) 58.43% compared to head (1e0975c) 58.27%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4885      +/-   ##
===========================================
- Coverage    58.43%   58.27%   -0.16%     
===========================================
  Files          588      588              
  Lines        53608    53655      +47     
===========================================
- Hits         31328    31270      -58     
- Misses       22280    22385     +105     
Impacted Files Coverage Δ
openbb_terminal/account/account_controller.py 81.02% <0.00%> (-1.78%) ⬇️
...mmon/technical_analysis/custom_indicators_model.py 20.83% <0.00%> (ø)
...minal/common/technical_analysis/volatility_view.py 32.81% <ø> (ø)
...lots/plotly_ta/plugins/custom_indicators_plugin.py 14.13% <0.00%> (ø)
openbb_terminal/core/sdk/sdk_init.py 92.75% <ø> (ø)
openbb_terminal/core/session/routines_handler.py 63.52% <0.00%> (-20.02%) ⬇️
...b_terminal/econometrics/econometrics_controller.py 47.40% <ø> (ø)
openbb_terminal/featflags_controller.py 84.81% <ø> (-3.15%) ⬇️
openbb_terminal/forecast/forecast_controller.py 1.12% <0.00%> (ø)
openbb_terminal/helper_funcs.py 49.69% <0.00%> (-0.44%) ⬇️
... and 21 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tehcoderer tehcoderer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmaslek jmaslek added this pull request to the merge queue Apr 24, 2023
Merged via the queue into develop with commit 8ce8380 Apr 24, 2023
@jmaslek jmaslek deleted the hotfix/last-minute-fixes branch May 1, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants