Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle inf. values inside lambda_long_number_format #4888

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Apr 25, 2023

@montezdesousa montezdesousa added the bug Fix bug label Apr 25, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 36.13% and project coverage change: -0.16 ⚠️

Comparison is base (a1aff50) 58.43% compared to head (6e8fa17) 58.28%.

❗ Current head 6e8fa17 differs from pull request most recent head 16868cc. Consider uploading reports for the commit 16868cc to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4888      +/-   ##
===========================================
- Coverage    58.43%   58.28%   -0.16%     
===========================================
  Files          588      588              
  Lines        53608    53657      +49     
===========================================
- Hits         31328    31272      -56     
- Misses       22280    22385     +105     
Impacted Files Coverage Δ
openbb_terminal/account/account_controller.py 81.02% <0.00%> (-1.78%) ⬇️
...mmon/technical_analysis/custom_indicators_model.py 20.83% <0.00%> (ø)
...minal/common/technical_analysis/volatility_view.py 32.81% <ø> (ø)
...lots/plotly_ta/plugins/custom_indicators_plugin.py 14.13% <0.00%> (ø)
openbb_terminal/core/sdk/sdk_init.py 92.75% <ø> (ø)
openbb_terminal/core/session/routines_handler.py 63.52% <0.00%> (-20.02%) ⬇️
...b_terminal/econometrics/econometrics_controller.py 47.40% <ø> (ø)
openbb_terminal/featflags_controller.py 84.81% <ø> (-3.15%) ⬇️
openbb_terminal/forecast/forecast_controller.py 1.12% <0.00%> (ø)
openbb_terminal/reports/reports_controller.py 75.00% <ø> (ø)
... and 22 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@montezdesousa montezdesousa requested a review from hjoaquim April 25, 2023 13:55
@jmaslek jmaslek added this pull request to the merge queue Apr 25, 2023
Merged via the queue into develop with commit 762a8d4 Apr 25, 2023
@montezdesousa montezdesousa deleted the hotfix/fix4887 branch April 25, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] stocks/fa/income --ratios - hangs indefinitely and ctrl-c must be used to break. --source FMP only.
2 participants