Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stocks/ta/vwap #4894

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Fix stocks/ta/vwap #4894

merged 2 commits into from
Apr 25, 2023

Conversation

hjoaquim
Copy link
Contributor

^

Fixes #4481

After fix:

image

@hjoaquim hjoaquim added the bug Fix bug label Apr 25, 2023
@hjoaquim hjoaquim requested a review from jmaslek April 25, 2023 13:40
@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 25, 2023
@montezdesousa montezdesousa self-requested a review April 25, 2023 13:47
@hjoaquim hjoaquim enabled auto-merge April 25, 2023 13:49
@hjoaquim hjoaquim added this pull request to the merge queue Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 40.87% and project coverage change: -0.16 ⚠️

Comparison is base (a1aff50) 58.43% compared to head (70c260b) 58.28%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4894      +/-   ##
===========================================
- Coverage    58.43%   58.28%   -0.16%     
===========================================
  Files          588      588              
  Lines        53608    53663      +55     
===========================================
- Hits         31328    31276      -52     
- Misses       22280    22387     +107     
Impacted Files Coverage Δ
generate_sdk.py 90.82% <ø> (ø)
openbb_terminal/account/account_controller.py 81.02% <0.00%> (-1.78%) ⬇️
...mmon/technical_analysis/custom_indicators_model.py 20.83% <0.00%> (ø)
...minal/common/technical_analysis/volatility_view.py 32.81% <ø> (ø)
...lots/plotly_ta/plugins/custom_indicators_plugin.py 14.13% <0.00%> (ø)
openbb_terminal/core/sdk/sdk_init.py 92.75% <ø> (ø)
openbb_terminal/core/session/routines_handler.py 63.52% <0.00%> (-20.02%) ⬇️
...b_terminal/econometrics/econometrics_controller.py 47.40% <ø> (ø)
openbb_terminal/featflags_controller.py 84.81% <ø> (-3.15%) ⬇️
openbb_terminal/forecast/forecast_controller.py 1.12% <0.00%> (ø)
... and 26 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Merged via the queue into OpenBB-finance:develop with commit 77dfd69 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] /stocks/ta/vwap: Error: can't compare datetime.datetime to datetime.date
2 participants