Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Futures Curve: minor cosmetic improvements #4901

Merged

Conversation

skhan877
Copy link
Contributor

Catering for #4886

  1. Raw table column name changed from "Futures" to "Last Price" - in both interactive and basic view.
  2. Contract names "prettified" more in-line with convention (mmm-yyyy). Also amends excel output format.

image

image

image

  1. Curve graph x-axis lines up actual contract months now, rather than continuous dates.

image

…port. change column header to Last Price. set x axis of curve chart to correspond to contract months
@reviewpad reviewpad bot added the feat XS Extra small feature label Apr 25, 2023
@deeleeramone
Copy link
Contributor

Hi @skhan59bbk, thanks for the PR and the improvement! The code linting is failing because it has not been formatted according to Black's wishes. Run it from the command line at the root of the OpenBBTerminal folder:

black openbb_terminal/futures

However, because the expected outputs have been changed, you will also have to re-record the unit test cassettes so that the changes to the results are captured.

pytest tests/openbb_terminal/futures --rewrite-expected 

This will update a few files in the /tests folder. Add those, along with the changes made by the code linting to the yfinance_model and yfinance_view files, in a commit.

@deeleeramone deeleeramone linked an issue Apr 26, 2023 that may be closed by this pull request
@skhan877
Copy link
Contributor Author

Ah my bad. Linting fixed but pytest is asking me to uninstall brotli - is this expected?

image

@jmaslek
Copy link
Collaborator

jmaslek commented Apr 26, 2023

Ah my bad. Linting fixed but pytest is asking me to uninstall brotli - is this expected?

image

Yes. We have historically run into some issues with the encoding used there. pip uninstall brotli -y then you can rewrite the tests

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (1444141) 58.28% compared to head (84d4cfb) 58.29%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4901   +/-   ##
========================================
  Coverage    58.28%   58.29%           
========================================
  Files          588      588           
  Lines        53667    53665    -2     
========================================
+ Hits         31280    31282    +2     
+ Misses       22387    22383    -4     
Impacted Files Coverage Δ
openbb_terminal/futures/yfinance_view.py 69.86% <ø> (ø)
openbb_terminal/terminal_controller.py 17.45% <0.00%> (+0.08%) ⬆️
openbb_terminal/helper_funcs.py 49.69% <50.00%> (+<0.01%) ⬆️
openbb_terminal/futures/yfinance_model.py 81.69% <100.00%> (-0.26%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek jmaslek enabled auto-merge April 27, 2023 18:52
@jmaslek jmaslek added this pull request to the merge queue Apr 27, 2023
Merged via the queue into OpenBB-finance:develop with commit b951e44 Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVE] Futures Curve Tenor Display
3 participants