Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/disc DappRadar update #4918

Merged
merged 24 commits into from
May 3, 2023
Merged

Conversation

IgorWounds
Copy link
Contributor

Updated the DappRadar endpoints to accommodate the new API key addition.

Added all available free tier endpoints, and updated the unit tests and the integration test.

TODO: Once merged, this will need to be tested with the Hub.

This closes #4358

@IgorWounds IgorWounds added bug Fix bug tests Test-related work crypto Crypto related labels Apr 27, 2023
@IgorWounds IgorWounds requested review from jmaslek and hjoaquim April 27, 2023 13:54
@reviewpad reviewpad bot added the feat XL Extra Large feature label Apr 27, 2023
@IgorWounds IgorWounds marked this pull request as draft April 27, 2023 13:55
@IgorWounds IgorWounds marked this pull request as ready for review April 27, 2023 20:00
Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicee!

@IgorWounds IgorWounds enabled auto-merge May 2, 2023 20:35
@IgorWounds IgorWounds disabled auto-merge May 2, 2023 20:48
@IgorWounds IgorWounds requested a review from colin99d May 2, 2023 21:17
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 60.53% and project coverage change: -0.19 ⚠️

Comparison is base (df9a154) 58.29% compared to head (0e6e629) 58.10%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4918      +/-   ##
===========================================
- Coverage    58.29%   58.10%   -0.19%     
===========================================
  Files          588      588              
  Lines        53666    53821     +155     
===========================================
- Hits         31283    31272      -11     
- Misses       22383    22549     +166     
Impacted Files Coverage Δ
.../core/plots/plotly_ta/plugins/volatility_plugin.py 31.37% <0.00%> (-1.29%) ⬇️
...inal/core/sdk/controllers/crypto_sdk_controller.py 0.00% <ø> (ø)
...inal/core/sdk/controllers/stocks_sdk_controller.py 0.00% <ø> (ø)
...penbb_terminal/core/sdk/models/crypto_sdk_model.py 0.00% <0.00%> (ø)
...penbb_terminal/core/sdk/models/stocks_sdk_model.py 0.00% <0.00%> (ø)
openbb_terminal/core/sdk/sdk_helpers.py 36.92% <ø> (ø)
openbb_terminal/core/sdk/sdk_init.py 92.75% <ø> (ø)
openbb_terminal/core/sdk/trailmap.py 92.68% <ø> (ø)
openbb_terminal/dashboards/stream/Forecasting.py 0.00% <0.00%> (ø)
...bb_terminal/dashboards/stream/streamlit_helpers.py 0.00% <0.00%> (ø)
... and 32 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@IgorWounds IgorWounds enabled auto-merge May 3, 2023 11:14
@IgorWounds IgorWounds added this pull request to the merge queue May 3, 2023
Merged via the queue into develop with commit 3037267 May 3, 2023
@IgorWounds IgorWounds deleted the feature/crypto-disc-dappradar branch May 3, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug crypto Crypto related feat XL Extra Large feature tests Test-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] dappradar cmds under crypto/disc
3 participants