fixing equity report issue

[andrewkenreich]

Description

This fixes the equity reports - a SDK command was deleted and new one wasn't being used

• Summary of the change / bug fix.
• Link # issue, if applicable.
• Screenshot of the feature or the bug before/after fix, if applicable.
• Relevant motivation and context.
• List any dependencies that are required for this change.

How has this been tested?

• Please describe the tests that you ran to verify your changes.
• Provide instructions so we can reproduce.
• Please also list any relevant details for your test configuration.

• Make sure affected commands still run in terminal
• Ensure the SDK still works
• Check any related reports

Checklist:

• I have adhered to the GitFlow naming convention and my branch name is in the format of feature/feature-name or hotfix/hotfix-name.
• Update our documentation following these guidelines. Update any user guides that are affected by the changes.
• Update our tests following these guidelines.
• Make sure you are following our CONTRIBUTING guidelines.
• If a feature was added make sure to add it to the corresponding integration test script.

Others

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.

[codecov]

Codecov Report

Patch coverage: 42.44% and project coverage change: -0.21 ⚠️

Comparison is base (df9a154) 58.29% compared to head (67f12fc) 58.08%.

❗ Current head 67f12fc differs from pull request most recent head 2066446. Consider uploading reports for the commit 2066446 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4922      +/-   ##
===========================================
- Coverage    58.29%   58.08%   -0.21%     
===========================================
  Files          588      588              
  Lines        53666    53687      +21     
===========================================
- Hits         31283    31183     -100     
- Misses       22383    22504     +121     

Impacted Files	Coverage Δ
.../core/plots/plotly_ta/plugins/volatility_plugin.py	31.37% <0.00%> (-1.29%)	⬇️
...inal/core/sdk/controllers/crypto_sdk_controller.py	0.00% <ø> (ø)
...inal/core/sdk/controllers/stocks_sdk_controller.py	0.00% <ø> (ø)
...penbb_terminal/core/sdk/models/crypto_sdk_model.py	0.00% <0.00%> (ø)
...bb_terminal/core/sdk/models/portfolio_sdk_model.py	0.00% <0.00%> (ø)
...penbb_terminal/core/sdk/models/stocks_sdk_model.py	0.00% <0.00%> (ø)
openbb_terminal/core/sdk/sdk_helpers.py	36.92% <ø> (ø)
openbb_terminal/core/sdk/sdk_init.py	92.75% <ø> (ø)
openbb_terminal/core/sdk/trailmap.py	92.68% <ø> (ø)
openbb_terminal/dashboards/stream/Forecasting.py	0.00% <0.00%> (ø)
... and 24 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[deeleeramone]

The data request here is going to be problematic, and will always return nothing. Should be, company_name, right?

tables = openbb.etf.news(info["Short name"][0], 5) if "Short name" in info else symbol

[deeleeramone]

Data is failing to return from openbb.stocks.fa.analyst.

[deeleeramone]

Should probably avoid using sources that require an API key so that a demonstration notebook will work straight-out-of-the-box. We get weird results for similar companies to MSFT. RHT is an OTC penny stock, Reliq Health Technologies, from Canada. Not very much is similar between the two here.

The list of "Similar Companies" even includes, XLK, the Technology Sector ETF.

['CSCO', 'AAPL', 'SAP', 'RHT', 'IBM', 'ORCL', 'HPQ', 'GOOGL', 'XLK', 'MSFT']

[deeleeramone]

Not getting any insider data from one place, but it does exist when openbb.stocks.ins.stats() is used.

[deeleeramone]

A font is being called here, and the vast majority of people will not have it installed.

[deeleeramone]

@andrewkenreich I tried patching some additional items, try it out and lemme know what breaks.