-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test coverage #4969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #4969 +/- ##
===========================================
- Coverage 58.29% 57.98% -0.31%
===========================================
Files 588 589 +1
Lines 53666 53939 +273
===========================================
- Hits 31283 31275 -8
- Misses 22383 22664 +281
☔ View full report in Codecov by Sentry. |
IgorWounds
force-pushed
the
feature/integration-test-coverage
branch
from
May 4, 2023 13:51
3a355f2
to
d326b57
Compare
IgorWounds
force-pushed
the
feature/integration-test-coverage
branch
from
May 7, 2023 19:08
7edb4ac
to
1163357
Compare
…e' into feature/integration-test-coverage
…e' into feature/integration-test-coverage
…e' into feature/integration-test-coverage
montezdesousa
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows us to calculate the integration test coverage of the OpenBB Terminal. It obtains each controller and parses its commands and the parameters of each command. Then, it calculates the difference between all available commands and parameters and those that were used inside the integration test scripts.
To allow for this, a naming convention was put in place for the integration test scripts. The tool was used to improve the coverage of existing integration tests and new ones were added.
To obtain the integration test coverage of a single controller write the following:
To obtain coverage for all controllers do this:
To run the above command from the terminal write:
At the end of the terminal command run, which tests all controllers, a summary will be printed. This summary is automatically pushed to our Slack on nightly builds via the GitHub Actions workflow.
Note: The submenus that require pre-loaded data (e.g. ta, qa...) have their parameter coverage accuracy hindered due to the controllers not generating
choices_default
and thus are about 95% accurate.