Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Description on Fixedincome #5065

Merged
merged 5 commits into from
May 25, 2023
Merged

Fixes Description on Fixedincome #5065

merged 5 commits into from
May 25, 2023

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented May 24, 2023

Description

Fixes #5032

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label May 24, 2023
@colin99d
Copy link
Contributor Author

@deeleeramone does this work? Since the descriptions are really repetitive I just simplified them. I figure now since they are a smaller thing, we can just leave them outside of pywry and still show the chart.

@deeleeramone
Copy link
Contributor

@deeleeramone does this work? Since the descriptions are really repetitive I just simplified them. I figure now since they are a smaller thing, we can just leave them outside of pywry and still show the chart.

Ya, that's way better. I think the exact same scenario applies to, /fixedincome/cp

@jmaslek jmaslek added this pull request to the merge queue May 25, 2023
Merged via the queue into develop with commit e30da79 May 25, 2023
@piiq piiq deleted the hotfix/54032 branch June 4, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] /fixedincome/spot --description Function prints an extremely verbose output and also displays a chart.
3 participants