Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No guest if installer #5076

Merged
merged 11 commits into from
Jun 1, 2023
Merged

No guest if installer #5076

merged 11 commits into from
Jun 1, 2023

Conversation

montezdesousa
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label May 29, 2023
@montezdesousa montezdesousa added installer installer related updated and removed feat XS Extra small feature labels May 29, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label May 29, 2023
@montezdesousa montezdesousa marked this pull request as ready for review May 29, 2023 13:59
@montezdesousa montezdesousa marked this pull request as draft May 29, 2023 14:42
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat XS Extra small feature labels May 29, 2023
@montezdesousa montezdesousa requested a review from jmaslek May 29, 2023 17:35
@montezdesousa montezdesousa marked this pull request as ready for review May 29, 2023 17:35
@jmaslek
Copy link
Collaborator

jmaslek commented May 29, 2023

Can you trigger a build (or link here if you have already :D)

@montezdesousa
Copy link
Contributor Author

montezdesousa commented May 29, 2023

Can you trigger a build (or link here if you have already :D)

https://github.com/OpenBB-finance/OpenBBTerminal/actions/runs/5113422422

@jmaslek
Copy link
Collaborator

jmaslek commented May 30, 2023

Can we have something that breaks the login flow if enter is just hit on the email or password. I.e from this:

Please enter your credentials:
> Email:
> Password:

To

Please enter your credentials:
> Email:
Please enter your credentials:
> Email:

@montezdesousa
Copy link
Contributor Author

Can we have something that breaks the login flow if enter is just hit on the email or password. I.e from this:

Please enter your credentials:
> Email:
> Password:

To

Please enter your credentials:
> Email:
Please enter your credentials:
> Email:

Should be there now

Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfectooooo

@jmaslek jmaslek added this pull request to the merge queue Jun 1, 2023
Merged via the queue into develop with commit 1539793 Jun 1, 2023
@piiq piiq deleted the feature/no_guest branch June 4, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature installer installer related updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants