Feature/ Pywry login #5115
Merged
Feature/ Pywry login #5115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DidierRLopes
reviewed
Jun 9, 2023
| endpoint = {True: "login", False: "logout"}[login] | ||
|
|
||
| outgoing = dict( | ||
| json_data=dict(url=f"https://my.openbb.dev/{endpoint}?pywry=true"), |
There was a problem hiding this comment.
needs to be changed to .co for production
There was a problem hiding this comment.
yes but first the frontend changes need to be pushed to "MY".openbb.co
DidierRLopes
reviewed
Jun 9, 2023
| @@ -1,4 +1,4 @@ | |||
| BASE_URL = "https://payments.openbb.co/" | |||
| BASE_URL = "https://payments.openbb.dev/" # TODO: Change this back to the .co domain | |||
…ce/OpenBBTerminal into feature/pywry-login
…ce/OpenBBTerminal into feature/pywry-login
jmaslek
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abilities In Pywry window:
accountmenu )accountmenu )accountmenu )Test login using .dev account.
TODO
revert BASE_URL to "https://payments.openbb.co/" when changes pushed to prod
update oauth when pushed to prodKnowns
Possibility of chargebee recaptcha popup windowfixedgoogle oauth needs to be updated from google dev console to authorize openbb domains cough cough @DidierRLopes