Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved market cap value extraction #5169

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

bimbolimbo
Copy link
Contributor

issue #5156

the market capitalization value is now explicitly converted to a string to ensure that all following operations are performed on a string data type, thus helping to avoid any potential type-related errors. Additionally, I've refined our approach for identifying the units of market capitalization: instead of simply checking if the value contains "M", "B", or "T" anywhere, we now check if the value ends with these characters, resulting in more accurate identification.

@reviewpad reviewpad bot added the feat XS Extra small feature label Jun 22, 2023
@deeleeramone
Copy link
Contributor

Hi @bimbolimbo, and thanks for the PR!

All PRs must strictly follow GitFlow naming convention.

/hotfix/branch-name
/feature/branch-name

This one would fall under the hotfix category.

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jmaslek
❌ bimbolimbo
You have signed the CLA already but the status is still pending? Let us recheck it.

@jmaslek jmaslek disabled auto-merge November 8, 2023 22:50
@jmaslek jmaslek merged commit acf8b06 into OpenBB-finance:develop Nov 8, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants