Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/fix-stocks-search-sdk3: Fixes the stocks search so that it doesn't print_rich_table() for SDK. #5329

Merged
merged 6 commits into from
Aug 17, 2023

Conversation

deeleeramone
Copy link
Contributor

Currently, if you use the SDK and stocks.search(), it will open a PyWry window while simultaneously returning a DataFrame. This takes care of that.

@deeleeramone deeleeramone requested a review from jmaslek August 15, 2023 23:08
@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Aug 15, 2023
@@ -1108,3 +1073,45 @@ def heikin_ashi(data: pd.DataFrame) -> pd.DataFrame:
]

return pd.concat([data, ha], axis=1)


def calculate_adjusted_prices(df: pd.DataFrame, column: str, dividends: bool = False):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helper was committed unintentionally and is part of fixing something unrelated. It can stay or go, but can be used to help fix some issues with the AlphaVantage adjusted prices data.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id rather it not be in, but it hurts nothing

@jmaslek jmaslek added this pull request to the merge queue Aug 17, 2023
Merged via the queue into develop with commit a6e66f7 Aug 17, 2023
@piiq piiq deleted the hotfix/fix-stocks-search-sdk3 branch August 28, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants