Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the CPI CSV and remove twitter functionalities #5350

Merged
merged 13 commits into from
Aug 18, 2023
Merged

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Aug 18, 2023

This fixes #5315 (I think).

I did this programatically, so @deeleeramone feel free to double check.

This also includes removing twitter functionalities. Really thought I added that to the previous release, but it seems I did not (or it got squashed and something weird goin on)

@jmaslek jmaslek added the feat XS Extra small feature label Aug 18, 2023
@jmaslek jmaslek requested a review from deeleeramone August 18, 2023 17:02
@reviewpad reviewpad bot added feat M Medium T-Shirt size feature and removed feat XS Extra small feature labels Aug 18, 2023
@jmaslek
Copy link
Collaborator Author

jmaslek commented Aug 18, 2023

Y twitter commits here

@jmaslek
Copy link
Collaborator Author

jmaslek commented Aug 18, 2023

Did I not add this to release. RIP

@jmaslek jmaslek changed the title Hotfix/cpi csv Fix the CPI CSV and remove twitter functionalities Aug 18, 2023
@reviewpad reviewpad bot added feat L Large T-Shirt size Feature and removed feat M Medium T-Shirt size feature labels Aug 18, 2023
@deeleeramone
Copy link
Contributor

deeleeramone commented Aug 18, 2023

CPI seems better, manually curating the list would have made it easy to mess up. Should we add "All Items" to the chart title?

Before:

image

After:

Screenshot 2023-08-18 at 10 32 53 AM

Twitter is still in the keys menu.

Screenshot 2023-08-18 at 10 37 14 AM

@jmaslek
Copy link
Collaborator Author

jmaslek commented Aug 18, 2023

CPI seems better, manually curating the list would have made it easy to mess up. Should we add "All Items" to the chart title?

Before:

image

After:

Screenshot 2023-08-18 at 10 32 53 AM

Twitter is still in the keys menu.

Screenshot 2023-08-18 at 10 37 14 AM

Twitter key removed.

Also programatically confirmed that all the Harmonized csvs are good

@colin99d colin99d self-requested a review August 18, 2023 17:50
@colin99d colin99d enabled auto-merge August 18, 2023 17:50
@colin99d colin99d added this pull request to the merge queue Aug 18, 2023
Merged via the queue into develop with commit 3fcb64d Aug 18, 2023
@piiq piiq deleted the hotfix/cpi-csv branch August 28, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat L Large T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] CPI Series ID curation is not mapped correctly, Y/Y and M/M are backwards for some countries.
3 participants