Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On the SDK, we were getting logs messages printed on notebooks - this was because notebooks come with handlers by default (see Notebook has a root logging handler installed by default ipython/ipython#8282 for more context).
The solution proposed on this PR is to clean the root logger handler, if any, during
setup_handlers()
.Also, took the opportunity to:
filter empty credentials incoming from the hub
encapsulated the usage of a variable that is created of the cost of calling a function inside a function so we don't have unnecessary executions during initialization
Link # issue, if applicable.
NA
Screenshot of the feature or the bug before/after fix, if applicable.
Before
After
Relevant motivation and context.
🐛 ☠️
List any dependencies that are required for this change.
NA
How has this been tested?
Just initialize the SDK:
from openbb_terminal.sdk import openbb
Checklist:
feature/feature-name
orhotfix/hotfix-name
.Others