Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix stock screener #5440

Merged
merged 6 commits into from
Sep 20, 2023
Merged

Hotfix stock screener #5440

merged 6 commits into from
Sep 20, 2023

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Sep 15, 2023

Fixes #5361

Screenshot 2023-09-15 at 12 55 07 PM

Screenshot 2023-09-15 at 12 56 26 PM

@jmaslek jmaslek added the bug Fix bug label Sep 15, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Sep 15, 2023
@deeleeramone
Copy link
Contributor

You know what's weird? If my filename contains "rsi", it fails. I have a preset in my OpenBBUserData folder called above50_rsi, and removing rsi from the filename allows it to be read.

(🦋) /stocks/scr/ $ view -p above50

 - General -
Order: Ticker


 - Descriptive -
Index: S&P 500


 - Fundamental -


 - Technical -
RSI (14): Not Oversold (>50)

Screenshot 2023-09-15 at 12 08 58 PM

@jmaslek
Copy link
Collaborator Author

jmaslek commented Sep 19, 2023

You know what's weird? If my filename contains "rsi", it fails. I have a preset in my OpenBBUserData folder called above50_rsi, and removing rsi from the filename allows it to be read.

(🦋) /stocks/scr/ $ view -p above50

 - General -
Order: Ticker


 - Descriptive -
Index: S&P 500


 - Fundamental -


 - Technical -
RSI (14): Not Oversold (>50)

Screenshot 2023-09-15 at 12 08 58 PM

try now

@deeleeramone
Copy link
Contributor

try now

mo' better!

@jmaslek jmaslek added this pull request to the merge queue Sep 20, 2023
Merged via the queue into develop with commit bf082d1 Sep 20, 2023
16 checks passed
@piiq piiq deleted the hotfix/screener branch September 28, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Screener preset names are being truncated by the Terminal/SDK. not_oversold is read as ot_oversold
2 participants