-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add etf holding performance #5488
Feature/add etf holding performance #5488
Conversation
Hey, thanks for this! Awesome to see! When I run this command with SPY, I end up getting a 404 error:
Since this loop takes some time, could you add a progress bar? We have a function in rich_helpers.py called Also when we have "Number of holdings to get" is it sorted by holding %? |
This is great!! FMP does allow gang-loading of tickers, so that might be a way to get around looping the historical data request. It would be good to know what the limitations are (don't trust their documentation) for multi-ticker historical data. Like, QQQ would work but not SPY, or even lower? |
The 404 is caused by the FMP endpoint not finding that specific ticker. I will maybe add some more info for when that occurs. Thank you for that info, I'll start working to add a progress bar. I'll also to make sure we sort by holding percentage rather than percent change. Makes more sense. |
I've been playing around with this. Only allows 5 tickers at a time for, but still worth it to utilize that. |
Thanks! I just did a super small edit to sort in descending order and then to keep the args --start-date/--end-date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added to default data sources json
Description
New terminal command based on #3820. Use loaded ETF ticker to search for current holdings, then find percent change for each stock in fund over specified date. Able to display data in bar chart or table.
etf -> holding_perf