Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Modify 'load' behavior to append data to existing sheet #5503

Merged
merged 6 commits into from
Oct 14, 2023
Merged

fix: Modify 'load' behavior to append data to existing sheet #5503

merged 6 commits into from
Oct 14, 2023

Commits on Oct 1, 2023

  1. fix: Modify 'load' behavior to append data to existing sheet 

    Details:
- Added logic to detect existing sheet and append data if present.
- There is no direct way to append on the sheet, so I am reading the sheet to get the last row number and then writing after that row number.

Resolves: OpenBB-finance#5472
    @ssahaxd
    ssahaxd committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    156af94 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Fixed 'worksheet not found' error during export to an existing sheet

    @ssahaxd
    ssahaxd committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    e7378e5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/append-to-sheet-export

    @ssahaxd
    ssahaxd authored Oct 2, 2023
    Configuration menu
    Copy the full SHA
    9474bfc View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Changes: 

    * Now if the sheet exists in the xlsx file it will ask the user if he
  wants to replace/append/create new sheet
    @ssahaxd
    ssahaxd committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e055ba6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/append-to-sheet-export

    @deeleeramone
    deeleeramone authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    320309f View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. Merge branch 'develop' into feature/append-to-sheet-export

    @deeleeramone
    deeleeramone authored Oct 14, 2023
    Configuration menu
    Copy the full SHA
    5ce9432 View commit details
    Browse the repository at this point in the history