Release 3.2.3

.github/workflows/linting.yml

@@ -44,7 +44,7 @@ jobs:
           restore-keys: ${{ runner.os }}-linting-${{ hashFiles('**/poetry.lock') }}
 
       - run: |
-          pip install bandit black codespell mypy==1.5.1 pylint==2.17.0 ruff==0.0.285
+          pip install bandit black codespell==2.2.5 mypy==1.5.1 pylint==2.17.0 ruff==0.0.285
           pip install types-pytz types-requests types-termcolor types-tabulate types-PyYAML types-python-dateutil types-setuptools types-six
       - run: bandit -x ./tests -r . || true
       - run: black --diff --check .

build/docker/compose.env

@@ -1,2 +1,2 @@
 OPENBBTERMINAL_DOCKER_REGISTRY="ghcr.io"
-OPENBBTERMINAL_DOCKER_RELEASE_VERSION="3.2.2"
+OPENBBTERMINAL_DOCKER_RELEASE_VERSION="3.2.3"

build/nsis/setup.nsi

@@ -10,18 +10,18 @@
   !define NAME "OpenBB Terminal"
   !define COMPANY "OpenBB"
   !define APPFILE "OpenBBTerminal.exe"
-  !define VERSION "3.2.2"
+  !define VERSION "3.2.3"
   !define SLUG "${NAME} v${VERSION}"
 
 ;--------------------------------
 ; Info for Installer.exe
-  VIProductVersion 3.2.0.0
+  VIProductVersion 3.2.3.0
   VIAddVersionKey ProductName "OpenBB Terminal"
   VIAddVersionKey Comments "An installer for OpenBB Terminal. For additional details, visit OpenBB.co"
   VIAddVersionKey CompanyName OpenBB.co
   VIAddVersionKey FileDescription "OpenBB Terminal Program"
-  VIAddVersionKey FileVersion 3.2.2.0
-  VIAddVersionKey ProductVersion 3.2.2.0
+  VIAddVersionKey FileVersion 3.2.3.0
+  VIAddVersionKey ProductVersion 3.2.3.0
   VIAddVersionKey InternalName "OpenBB Terminal"
 
 ;--------------------------------

build/pyinstaller/.env

@@ -24,4 +24,3 @@ OPENBB_USE_DATETIME=true
 OPENBB_OPEN_REPORT_AS_HTML=true
 OPENBB_ENABLE_QUICK_EXIT=false
 OPENBB_ENABLE_EXIT_AUTO_HELP=false
-PYWRY_EXECUTABLE=OpenBBPlotsBackend

build/pyinstaller/macOS/build-macos.sh

@@ -119,6 +119,7 @@ signFiles() {
     echo "Code Sign OpenBB Executable File"
     codesign --deep --force --verify --verbose --options runtime --entitlements "$ENTITLEMENTS" -s "$APPLE_SIGNING_IDENTITY" build/pyinstaller/macOS/target/darwinpkg/Applications/OpenBB\ Terminal/.OpenBB/OpenBBTerminal
     codesign --deep --force --verify --verbose --options runtime --entitlements "$ENTITLEMENTS" -s "$APPLE_SIGNING_IDENTITY" build/pyinstaller/macOS/target/darwinpkg/Applications/OpenBB\ Terminal/.OpenBB/OpenBBPlotsBackend
+    codesign --deep --force --verify --verbose --options runtime --entitlements "$ENTITLEMENTS" -s "$APPLE_SIGNING_IDENTITY" build/pyinstaller/macOS/target/darwinpkg/Applications/OpenBB\ Terminal/.OpenBB/pywry
 }
 
 createInstallationDirectory() {

build/pyinstaller/setup_icons_post.applescript

@@ -13,8 +13,8 @@ set destPath to current_path & "../../DMG/OpenBB Terminal/.OpenBB/OpenBBTerminal
 set imageData to (current application's NSImage's alloc()'s initWithContentsOfFile:sourcePath)
 (current application's NSWorkspace's sharedWorkspace()'s setIcon:imageData forFile:destPath options:2)
 
--- Set OpenBB OpenBBPlotsBackend icon relative to script location
+-- Set OpenBB pywry icon relative to script location
 set sourcePath to current_path & "../../images/openbb.icns"
-set destPath to current_path & "../../DMG/OpenBB Terminal/.OpenBB/OpenBBPlotsBackend"
+set destPath to current_path & "../../DMG/OpenBB Terminal/.OpenBB/pywry"
 set imageData to (current application's NSImage's alloc()'s initWithContentsOfFile:sourcePath)
 (current application's NSWorkspace's sharedWorkspace()'s setIcon:imageData forFile:destPath options:2)

build/pyinstaller/terminal.spec

@@ -1,5 +1,6 @@
 # -*- mode: python ; coding: utf-8 -*-  # noqa
 import os
+from shutil import which
 import subprocess
 import sys
 from pathlib import Path
@@ -27,11 +28,10 @@ venv_path = Path(sys.executable).parent.parent.resolve()
 # Check if we are running in a conda environment
 if is_darwin:
     pathex = os.path.join(os.path.dirname(os.__file__), "site-packages")
+elif "site-packages" in list(venv_path.iterdir()):
+    pathex = str(venv_path / "site-packages")
 else:
-    if "site-packages" in list(venv_path.iterdir()):
-        pathex = str(venv_path / "site-packages")
-    else:
-        pathex = str(venv_path / "lib" / "site-packages")
+    pathex = str(venv_path / "lib" / "site-packages")
 
 pathex = Path(pathex).resolve()
 
@@ -76,6 +76,7 @@ added_files = [
     (str(pathex / "llama_index/VERSION"), "llama_index"),
     (str(pathex / "tiktoken"), "tiktoken"),
     (str(pathex / "tiktoken_ext"), "tiktoken_ext"),
+    (which("pywry"), "."),
 ]
 
 if is_win:
@@ -112,7 +113,7 @@ hidden_imports = [
     "_sysconfigdata__darwin_darwin",
     "prophet",
     "debugpy",
-    "pywry.pywry",
+    "pywry",
     "scipy.sparse.linalg._isolve._iterative",
     "whisper",
     "transformers",
@@ -154,45 +155,6 @@ if is_win:
 if is_darwin:
     exe_icon = (str(repo_path / "images/openbb.icns"),)
 
-block_cipher = None
-# PyWry
-pywry_a = Analysis(
-    [str(pathex / "pywry/backend.py")],
-    pathex=[],
-    binaries=[],
-    datas=[],
-    hiddenimports=[],
-    hookspath=[],
-    hooksconfig={},
-    runtime_hooks=[],
-    excludes=[],
-    win_no_prefer_redirects=False,
-    win_private_assemblies=False,
-    cipher=block_cipher,
-    noarchive=False,
-)
-pywry_pyz = PYZ(pywry_a.pure, pywry_a.zipped_data, cipher=block_cipher)
-
-
-# PyWry EXE
-pywry_exe = EXE(
-    pywry_pyz,
-    pywry_a.scripts,
-    [],
-    exclude_binaries=True,
-    name="OpenBBPlotsBackend",
-    debug=False,
-    bootloader_ignore_signals=False,
-    strip=False,
-    upx=True,
-    upx_exclude=[],
-    console=True,
-    disable_windowed_traceback=False,
-    target_arch="x86_64",
-    codesign_identity=None,
-    entitlements_file=None,
-    icon=exe_icon,
-)
 
 exe_args = [
     pyz,
@@ -252,14 +214,9 @@ if is_darwin:
     exe_kwargs["argv_emulation"] = True
 
 exe = EXE(*exe_args, **exe_kwargs)
-pywry_collect_args = [
-    pywry_a.binaries,
-    pywry_a.zipfiles,
-    pywry_a.datas,
-]
 
 if build_type == "folder":
     coll = COLLECT(
-        *([exe] + collect_args + [pywry_exe] + pywry_collect_args),
+        *([exe] + collect_args),
         **collect_kwargs,
     )

build/pyinstaller/version.rc

@@ -6,8 +6,8 @@ VSVersionInfo(
   ffi=FixedFileInfo(
     # filevers and prodvers should be always a tuple with four items: (1, 2, 3, 4)
     # Set not needed items to zero 0.
-    filevers=(3, 2, 2, 0),
-    prodvers=(3, 2, 2, 0),
+    filevers=(3, 2, 3, 0),
+    prodvers=(3, 2, 3, 0),
     # Contains a bitmask that specifies the valid bits 'flags'r
     mask=0x0,
     # Contains a bitmask that specifies the Boolean attributes of the file.
@@ -32,10 +32,10 @@ VSVersionInfo(
         [StringStruct('Comments', 'The OpenBB Terminal. For additional details, visit OpenBB.co'),
         StringStruct('CompanyName', 'OpenBB'),
         StringStruct('FileDescription', 'OpenBB Terminal Program'),
-        StringStruct('FileVersion', '3.2.2.0'),
+        StringStruct('FileVersion', '3.2.3.0'),
         StringStruct('InternalName', 'OpenBB Terminal'),
         StringStruct('ProductName', 'OpenBB Terminal'),
-        StringStruct('ProductVersion', '3.2.2.0')])
+        StringStruct('ProductVersion', '3.2.3.0')])
       ]),
     VarFileInfo([VarStruct('Translation', [1033, 1200])])
   ]

openbb_terminal/common/technical_analysis/overlap_model.py

@@ -55,7 +55,7 @@ def sma(data: pd.Series, length: int = 50, offset: int = 0) -> pd.DataFrame:
     Returns
     -------
     pd.DataFrame
-         Dataframe containing prices and SMA
+        Dataframe containing prices and SMA
     """
     if isinstance(data, pd.DataFrame):
         console.print("[red]Please send a series and not a DataFrame.[/red]\n")

openbb_terminal/core/models/credentials_model.py

@@ -1,5 +1,6 @@
 import json
 from dataclasses import make_dataclass
+from typing import Any, List, Tuple
 
 from pydantic.dataclasses import dataclass as pydanticdataclass
 
@@ -13,11 +14,13 @@
     LOCAL_CREDENTIALS = json.load(f)
 
 
+fields: List[Tuple[str, type, Any]] = [
+    (k, str, "REPLACE_ME") for k in list(HUB_CREDENTIALS) + list(LOCAL_CREDENTIALS)
+]
+
 dc = make_dataclass(
     cls_name="CredentialsModel",
-    fields=[
-        (k, str, "REPLACE_ME") for k in list(HUB_CREDENTIALS) + list(LOCAL_CREDENTIALS)
-    ],
+    fields=fields,
     bases=(BaseModel,),
 )
 dc.__repr__ = dc.__base__.__repr__  # type: ignore

openbb_terminal/core/models/system_model.py

@@ -28,7 +28,7 @@ class SystemModel(BaseModel):
     PLATFORM: str = str(platform.platform())
 
     # OpenBB section
-    VERSION: str = "3.2.2"
+    VERSION: str = "3.2.3"
 
     # Logging section
     LOGGING_APP_ID: str = "REPLACE_ME"

openbb_terminal/core/plots/plotly_helper.py

@@ -926,6 +926,10 @@ def chart_volume_scaling(
         """
         df_volume = df_volume.apply(lambda x: f"{x:.1f}")
         df_volume = pd.to_numeric(df_volume.astype(float))
+
+        if isinstance(df_volume, pd.Series):
+            df_volume = df_volume.to_frame()
+
         volume_ticks = int(df_volume.max().max())
         round_digits = -3
         first_val = round(volume_ticks * 0.20, round_digits)

openbb_terminal/core/plots/plotly_ta/ta_class.py

@@ -264,7 +264,7 @@ def _clear_data(self):
 
     def calculate_indicators(self):
         """Return dataframe with all indicators"""
-        return self.indicators.to_dataframe(self.df_stock.copy(), self.ma_mode)
+        return self.indicators.to_dataframe(self.df_stock, self.ma_mode)
 
     def get_subplot(self, subplot: str) -> bool:
         """Return True if subplots will be able to be plotted with current data"""

openbb_terminal/core/session/local_model.py

@@ -128,6 +128,7 @@ def set_credentials_from_hub(configs: dict):
     """
     if configs:
         credentials = configs.get("features_keys", {}) or {}
+        credentials = {k: v for k, v in credentials.items() if v}
         for k, v in credentials.items():
             set_credential(k, v)
 

openbb_terminal/cryptocurrency/onchain/bitquery_model.py

@@ -187,7 +187,7 @@ def query_graph(url: str, query: str) -> dict:
         ) from e
 
     if response.status_code == 500:
-        raise HTTPError(f"Internal sever error {response.reason}")
+        raise HTTPError(f"Internal sever error {response.reason}")  # type: ignore
 
     if not 200 <= response.status_code < 300:
         raise BitQueryApiKeyException(
@@ -816,4 +816,7 @@ def get_spread_for_crypto_pair(
     return df
 
 
-POSSIBLE_CRYPTOS = list(get_erc20_tokens()["symbol"].unique())
+@log_start_end(log=logger)
+def get_possible_crypto_symbols():
+    """Get possible crypto symbols."""
+    return list(get_erc20_tokens()["symbol"].unique())

openbb_terminal/cryptocurrency/onchain/onchain_controller.py

@@ -1395,7 +1395,7 @@ def call_baas(self, other_args: List[str]):
             dest="coin",
             type=str,
             help="ERC20 token symbol or address.",
-            choices=bitquery_model.POSSIBLE_CRYPTOS,
+            choices=bitquery_model.get_possible_crypto_symbols(),
             metavar="COIN",
         )
         parser.add_argument(
@@ -1444,7 +1444,8 @@ def call_baas(self, other_args: List[str]):
         )
         if ns_parser:
             if ns_parser.coin:
-                if ns_parser.coin in bitquery_model.POSSIBLE_CRYPTOS:
+                possible_cryptos = bitquery_model.get_possible_crypto_symbols()
+                if ns_parser.coin in possible_cryptos:
                     bitquery_view.display_spread_for_crypto_pair(
                         symbol=ns_parser.coin,
                         to_symbol=ns_parser.vs,
@@ -1464,7 +1465,7 @@ def call_baas(self, other_args: List[str]):
                     else:
                         similar_cmd = difflib.get_close_matches(
                             ns_parser.coin,
-                            bitquery_model.POSSIBLE_CRYPTOS,
+                            possible_cryptos,
                             n=1,
                             cutoff=0.75,
                         )
@@ -1486,7 +1487,7 @@ def call_baas(self, other_args: List[str]):
                         except Exception:
                             similar_cmd = difflib.get_close_matches(
                                 ns_parser.coin,
-                                bitquery_model.POSSIBLE_CRYPTOS,
+                                possible_cryptos,
                                 n=1,
                                 cutoff=0.5,
                             )

openbb_terminal/dashboards/stream/pages/Indicators.py

@@ -159,7 +159,12 @@ async def plot_indicators(
     ):
         annotation.xshift += -5
 
-    y_min, y_max = data["Low"].min().min(), data["High"].max().max()
+    min_max = {"min": data["Low"].min(), "max": data["High"].max()}
+    for attr in min_max:
+        if hasattr(min_max[attr], attr):
+            min_max[attr] = getattr(min_max[attr], attr)()
+
+    y_min, y_max = min_max["min"], min_max["max"]
     y_range = y_max - y_min
     y_min -= y_range * 0.05
     y_max += y_range * 0.05