Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug fix] - Run charting tests again #6167

Merged
merged 2 commits into from
Mar 5, 2024
Merged

[Bug fix] - Run charting tests again #6167

merged 2 commits into from
Mar 5, 2024

Conversation

montezdesousa
Copy link
Contributor

  1. Why?

    • openbb_charting integration tests were skipped
    • any obbject extension would be skipped in the future

  2. What?

    • Include obbject in the set of parametrize extensions

  3. Impact:

    • Tests run again

  4. Testing Done:

    • Install the openbb_charting extension and run integration tests

@montezdesousa montezdesousa added tests Test-related work v4 PRs for v4 labels Mar 5, 2024
@github-actions github-actions bot added bug Fix bug platform OpenBB Platform labels Mar 5, 2024
@montezdesousa montezdesousa removed the platform OpenBB Platform label Mar 5, 2024
@github-actions github-actions bot added the platform OpenBB Platform label Mar 5, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Mar 5, 2024
Merged via the queue into develop with commit b768bc0 Mar 5, 2024
15 checks passed
@IgorWounds IgorWounds deleted the bugfix/charting_tests branch March 7, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

@hjoaquim hjoaquim Awaiting requested review from hjoaquim

Assignees
No one assigned
Labels
bug Fix bug platform OpenBB Platform tests Test-related work v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@montezdesousa @IgorWounds