Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] - Test parametrize skips charting tests #6264

Merged
merged 25 commits into from
Mar 28, 2024

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Mar 28, 2024

  1. Why?

    • Charting tests were skipped inside @parametrized
  2. What?

    • Allow obbject extension tests to run without conditions on provider argument
    • Fixes some mypy issues in charting extension
  3. Impact (1-2 sentences or a bullet point list):

    • NA
  4. Testing Done:

    • NA

@montezdesousa montezdesousa requested a review from hjoaquim March 28, 2024 11:05
@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Mar 28, 2024
@montezdesousa montezdesousa enabled auto-merge March 28, 2024 15:35
@montezdesousa montezdesousa added this pull request to the merge queue Mar 28, 2024
Merged via the queue into develop with commit ce52ef3 Mar 28, 2024
14 checks passed
@deeleeramone
Copy link
Contributor

deeleeramone commented Mar 28, 2024

I'm still experiencing all integration tests skipped between test_charting_technical_adx and test_charting_technical_zlma, inclusively.

Cancel that. Didn't have the right local merge in place.

@IgorWounds IgorWounds deleted the bugfix/test_parametrize branch March 31, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants