Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] - PyDocstyle Compliant #6284

Merged
merged 22 commits into from
Apr 9, 2024
Merged

Conversation

IgorWounds
Copy link
Contributor

@IgorWounds IgorWounds commented Apr 3, 2024

Pull Request Template for OpenBB Developers

  1. Why? (1-3 sentences or a bullet point list):

    • To ensure the quality of code we want to comply with PyDocstyle.
  2. What? (1-3 sentences or a bullet point list):

    • Fixes and adds docstrings where needed to comply with PyDocstyle.
    • To ensure we follow PyDocstyle, it is added to the linters that run on each PR on changed files.
  3. Impact (1-2 sentences or a bullet point list):

    • Touched many files and changed their signatures. It shouldn't create breaking changes.
  4. Testing Done:

    • Made sure that te PyDocstyle check passes.

@github-actions github-actions bot added enhancement Enhancement platform OpenBB Platform v4 PRs for v4 labels Apr 3, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Apr 9, 2024
Merged via the queue into develop with commit a255fa5 Apr 9, 2024
10 checks passed
@IgorWounds IgorWounds deleted the feature/pydocstyle-compliant branch April 9, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants