Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HotFix] Add ETF holdings data param to Intrinio #6293

Merged
merged 3 commits into from
Apr 9, 2024
Merged

[HotFix] Add ETF holdings data param to Intrinio #6293

merged 3 commits into from
Apr 9, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • This parameter now exists from their API.,

  2. What?:

    • date parameter for the as-of date.

    • Daily holdings from 2018-04-02.

  3. Impact (1-2 sentences or a bullet point list):

    • Minimal, just added a parameter.

  4. Testing Done:

    • Went back as far as possible to find the beginning of the data.

Screenshot 2024-04-08 at 3 52 50 PM

@deeleeramone deeleeramone added platform OpenBB Platform v4 PRs for v4 labels Apr 8, 2024
@github-actions github-actions bot added bug Fix bug labels Apr 8, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Apr 9, 2024
Merged via the queue into develop with commit 0a64bd1 Apr 9, 2024
10 checks passed
@IgorWounds IgorWounds deleted the hotfix/intrinio-date-param branch April 9, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

Assignees
No one assigned
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deeleeramone @IgorWounds