-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Limit number of countries in TE request #6301
Conversation
Is there a reason why "All" is not used instead of trying to get a huge list? It could quite easily create a URL string that is too long for HTTP requests. It would be pretty simple to filter post-request, and storing that data in cache would dramatically reduce the number of API calls. |
Is Although, we can still set a limit for number of countries in one request, if TE has one (as it look it does), using the validator. |
All is what you get when you only enter a start/end date. A different way of going about restricting the length of the URL would be by the character count instead of the number of countries. 2000 characters is a general "safe" limit for URL length, although this can vary by platform. |
That seems to be the case - let's do that instead. |
Why? (1-3 sentences or a bullet point list):
What? (1-3 sentences or a bullet point list):
Impact (1-2 sentences or a bullet point list):
Testing Done:
openbb_platform/providers/tradingeconomics/openbb_tradingeconomics/utils/countries.py
:Reviewer Notes (optional):