Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix yFinance end_date filter when not intraday. #6302

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • When an end date is requested, handling for intraday was also adjusting the target date for non-intraday, resulting in an extra day being added.
  2. What? (1-3 sentences or a bullet point list):

    • Set flag so that if intraday, then add 719 minutes to capture all intraday values inclusive of the end_date.
  3. Impact (1-2 sentences or a bullet point list):

    • No more unexpected extra date.
  4. Testing Done:

    March 31, 2024 is a good test case because it is a Sunday, and we should not be getting April 1 when the data is daily/weekly/monthly.

    • obb.equity.price.historical("BTC-USD", start_date="2024-03-01", end_date="2024-03-31", provider="yfinance", interval="15m"
    • obb.equity.price.historical("QQQ", start_date="2024-01-01", end_date="2024-03-31", provider="yfinance")

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Apr 10, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Apr 11, 2024
Merged via the queue into develop with commit 00cc450 Apr 11, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/yfinance-end-date branch April 11, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants