[BugFix] - Provider is added to every response item #6305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
symbol
was dropped from multiple items responses, to fix that the response is dumped to adict
so that FastAPI validation doesn't dropsymbol
provider
field in the dumped response so that the discriminated union of outputs can be performed (provider
could not be excluded frommodel_dump
)provider
is added to every response item, but we don't need/want it thereWhat?
provider
field to discriminated the union, so it's not even a fieldProviderInterface::_generate_return_annotations
and remove it fromSignatureInspector::inject_return_type
symbol
stop being dropped from the response nowOBBject
that were used to create docstrings. Added same functionality (refactored) inDocstringGenerator
Impact:
provider
field added to every response resultsTesting Done: