Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix metadata creation #6306

Merged
merged 5 commits into from
Apr 11, 2024
Merged

[BugFix] Fix metadata creation #6306

merged 5 commits into from
Apr 11, 2024

Conversation

hjoaquim
Copy link
Contributor

  1. Why? (1-3 sentences or a bullet point list):

    • Metadata in a wrong format (namely json string) causes a poor UX.
  2. What? (1-3 sentences or a bullet point list):

    • Fixed iteration on the arguments so that the length of each argument is properly accessed.
  3. Impact (1-2 sentences or a bullet point list):

    • No impact (metadata is optional).
  4. Testing Done:

    • Running any endpoint with several arguments (before and after):
from openbb import obb
res = obb.equity.price.historical("AAPL,MSFT", provider="fmp", start_date="2022-01-01")
res.extra["metadata"]
  1. Reviewer Notes (optional):

    • NA
  2. Any other information (optional)

Before:
image

After:
image

@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Apr 11, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Apr 11, 2024
Merged via the queue into develop with commit 3172b9e Apr 11, 2024
10 checks passed
@hjoaquim hjoaquim deleted the bugfix/fix-metadata branch April 11, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants