Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fixes the API #6309

Merged
merged 3 commits into from
Apr 15, 2024
Merged

[BugFix] Fixes the API #6309

merged 3 commits into from
Apr 15, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • The API completely broke.
  2. What? (1-3 sentences or a bullet point list):

    • metadata.py is not unpacking the nested objects.
 AttributeError: 'LTIR' object has no attribute 'items'
  1. Impact (1-2 sentences or a bullet point list):

    • The API works.
  2. Testing Done:

Before:

image

After:

image

Screenshot 2024-04-12 at 10 07 47 AM

  1. Reviewer Notes:

    • Please run all the tests yourself.

@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Apr 12, 2024
@montezdesousa
Copy link
Contributor

I run the tests on develop and don't get any failure

image

@deeleeramone
Copy link
Contributor Author

I run the tests on develop and don't get any failure

Are you sure you have the latest changes pulled locally? This can be clearly identified as an issue within metadata.py.

Screenshot 2024-04-12 at 1 46 21 PM

Copy link
Contributor

@montezdesousa montezdesousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manage to reproduce in DEBUG_MODE

@montezdesousa montezdesousa added this pull request to the merge queue Apr 15, 2024
Merged via the queue into develop with commit 40ce132 Apr 15, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/fix-api branch April 15, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants