[BugFix] Chunk FMP Price Performance URL For Large Lists #6317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?:
obb.equity.price.performance(provider="fmp")
the URL string could be too long when passed a large list of symbols.What? (1-3 sentences or a bullet point list):
to_upper()
validator for the symbol parameter ofobb.etf.holdings()
.None
.Impact (1-2 sentences or a bullet point list):
obb.etf.holdings_performance()
in favour of making the user define the list of symbols themselves and useequity.price.performance()
instead.Testing Done:
The the list of holdings tickers in IWM as the list, it creates an error.
Before:
Where the root error code is:
414 Request-URI Too Large
After: