Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Intrinio News #6336

Merged
merged 7 commits into from
Apr 24, 2024
Merged

[BugFix] Intrinio News #6336

merged 7 commits into from
Apr 24, 2024

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented Apr 24, 2024

  1. Why?:

    • Optional field was missing default=None.
    • New data response adds parameters and response fields that need to be unpacked.
    • Intrinio API has broken parameters
      • page_size does not work
      • when source=yahoo, is_spam breaks the API request.
      • start/end dates when source!=yahoo don't appear to work.
  2. What? (1-3 sentences or a bullet point list):

    • Apply workarounds.
      • The current bug, at the source, forces the number of results at 20, which creates a huge bottleneck in the request where typically there are 100X that number of stories in a day.
  3. Impact (1-2 sentences or a bullet point list):

    • This will need to be revisited once they fix the issue with the broken parameters.
      • It now takes an unreasonable amount of time to fetch just one day's worth of world news.
  4. Testing Done:

    • New unit tests captured, expanded params in integration tests.

@deeleeramone deeleeramone added the bug Fix bug label Apr 24, 2024
@github-actions github-actions bot added platform OpenBB Platform v4 PRs for v4 labels Apr 24, 2024
@deeleeramone deeleeramone marked this pull request as ready for review April 24, 2024 03:58
@IgorWounds IgorWounds added this pull request to the merge queue Apr 24, 2024
Merged via the queue into develop with commit 3872738 Apr 24, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/intrinio-world-news branch April 24, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants