Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] - Fix lowercase symbols #6342

Merged
merged 11 commits into from
May 7, 2024
Merged

Conversation

IgorWounds
Copy link
Contributor

  1. Why? (1-3 sentences or a bullet point list):

    • The field_validator from the standard model wasn't being picked up by the CBOEDerivatesFetcher which resulted in errors when the symbol was lowercase.
  2. What? (1-3 sentences or a bullet point list):

    • Ensures all symbols passed to the CBOEDerivatesFetcher are uppercase.
  3. Impact (1-2 sentences or a bullet point list):

    • N/A
  4. Testing Done:

    • Ensured it works.

@IgorWounds IgorWounds requested a review from piiq April 25, 2024 14:50
@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Apr 25, 2024
@deeleeramone
Copy link
Contributor

deeleeramone commented Apr 25, 2024

This impacts all the other providers as well. Intrinio symbols are all case-sensitive.

Previously, upper() was done in the same place that enforced conversion of all "symbol" fields to a string from a list.

@IgorWounds IgorWounds requested a review from hjoaquim May 7, 2024 11:12
Copy link
Contributor

@hjoaquim hjoaquim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is gone.

@hjoaquim hjoaquim added this pull request to the merge queue May 7, 2024
Merged via the queue into develop with commit 5c0b36c May 7, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/cboe-derivatives-symbol branch May 7, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants