Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Filtered provider arguments #6348

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

hjoaquim
Copy link
Contributor

Pull Request Template for OpenBB Developers

  1. Why? (1-3 sentences or a bullet point list):

    • Unexpected results on command execution within the CLI.
  2. What? (1-3 sentences or a bullet point list):

    • Track the provider parameters name while parsing the groups so that those can be checked against later, instead of signature only (since provider parameters are not on the signature).
  3. Impact (1-2 sentences or a bullet point list):

    • NA - UX improvement on the CLI.
  4. Testing Done:

    • Running screener --exchange asx --sector Energy on the CLI before and after and observe that the sector is now being properly filtered.

@hjoaquim hjoaquim added the cli OpenBB Platform CLI label Apr 29, 2024
@hjoaquim hjoaquim requested a review from montezdesousa April 29, 2024 10:04
@github-actions github-actions bot added the bug Fix bug label Apr 29, 2024
@IgorWounds IgorWounds enabled auto-merge April 29, 2024 10:51
@IgorWounds IgorWounds added this pull request to the merge queue Apr 29, 2024
Merged via the queue into develop with commit a502766 Apr 29, 2024
7 checks passed
@piiq piiq deleted the bugfix/provider-parameters branch May 7, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug cli OpenBB Platform CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants