Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Empty views on the CLI #6351

Merged
merged 2 commits into from
Apr 29, 2024
Merged

[BugFix] Empty views on the CLI #6351

merged 2 commits into from
Apr 29, 2024

Conversation

hjoaquim
Copy link
Contributor

  1. Why? (1-3 sentences or a bullet point list):

    • Enhance UX, broken results look bad.

  2. What? (1-3 sentences or a bullet point list):

    • Ensure everything on the dataframe is a text before sending it to be displayed by the backend.

  3. Impact (1-2 sentences or a bullet point list):

    • NA: UX improvement.

  4. Testing Done:

    • Running the following on the CLI: world/news ; world/company ; coverage/command_schemas

@hjoaquim hjoaquim added the cli OpenBB Platform CLI label Apr 29, 2024
@hjoaquim hjoaquim requested a review from IgorWounds April 29, 2024 14:44
@github-actions github-actions bot added the bug Fix bug label Apr 29, 2024
@hjoaquim hjoaquim added this pull request to the merge queue Apr 29, 2024
Merged via the queue into develop with commit 4105ec4 Apr 29, 2024
7 checks passed
@deeleeramone deeleeramone mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

Assignees
No one assigned
Labels
bug Fix bug cli OpenBB Platform CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjoaquim @IgorWounds