Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Remove Literal[None,...] #6371

Merged
merged 5 commits into from
May 7, 2024
Merged

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented May 7, 2024

  1. Why? (1-3 sentences or a bullet point list):

    • Add coherence and consistency - also fixes a misinterpretation on the CLI side (which was causing affected commands to not execute properly.
  2. What? (1-3 sentences or a bullet point list):

    • Remove Literal[None,...] and use Optional[Literal[...]] instead
  3. Impact (1-2 sentences or a bullet point list):

    • NA: the URLs for queries stay exactly the same when None is specified in the given argument (the same goes for the other options).
  4. Testing Done:

    • Run affected commands before and after. Eg: obb.economy.fred_series(symbol="DGS5", provider="fred", aggregation_method=None)

@hjoaquim hjoaquim added the platform OpenBB Platform label May 7, 2024
@github-actions github-actions bot added bug Fix bug v4 PRs for v4 labels May 7, 2024
hjoaquim and others added 4 commits May 7, 2024 11:14
…e/OpenBBTerminal into bugfix/remove-literal-none
tmpfs            3257224      3044   3254180   1% /run
/dev/nvme0n1p5 491732848 290872352 175808336  63% /
tmpfs           16286112     81500  16204612   1% /dev/shm
tmpfs               5120         8      5112   1% /run/lock
efivarfs             246        66       176  28% /sys/firmware/efi/efivars
tmpfs           16286112         0  16286112   0% /run/qemu
/dev/nvme0n1p1    262144     60008    202136  23% /boot/efi
tmpfs            3257220     15056   3242164   1% /run/user/1000 to avoid misleading linting attr errors
@hjoaquim
Copy link
Contributor Author

hjoaquim commented May 7, 2024

ps - no idea how that commit message got there (282bc94)

@IgorWounds IgorWounds added this pull request to the merge queue May 7, 2024
Merged via the queue into develop with commit 63723f7 May 7, 2024
10 checks passed
@hjoaquim hjoaquim deleted the bugfix/remove-literal-none branch May 7, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants