-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] - Create repo assets directory #6384
Conversation
@montezdesousa, should we include the https://github.com/OpenBB-finance/OpenBBTerminal/blob/develop/examples/content.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good!
Knowing that V3 is deprecated and discontinued, for how long should we keep the v3 credential mapping in our v4 architecture and mapping?
Should we migrate to the mapping of v4 at a certain point? cc: @andrewkenreich
Sounds good, is it auto-generated or we can just move it and redirect on the Hub? Edit: merged this to unblock the PR. |
Why?
providers.json
needed to be manually updatedWhat?
v3_credentials
are now defined in theProvider
classassets
folder for the repo. Applications that need to know any repo information should rely on this folder only.PROVIDERS.md
andEXTENSIONS.md
. These were not maintained and info is duplicated in multiple placesImpact:
providers.json
was already read by OpenBB Hub to provide credential hints, need to update that website before merging this code tomain
Testing Done: