Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Make paper_bgcolor transparent in PyWry backend #6385

Merged
merged 7 commits into from
May 14, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

  2. What? (1-3 sentences or a bullet point list):

    • The process in [BugFix] Set Chart Style Before Output #6367 sets the value so that it displays in a web browser or Jupyter environment. However, for display in PyWry, we need to make it transparent to avoid incompatibilities with the light/dark toggle button on the mode bar.

    • This updates the json_data immediately before output so that the Figure object itself is not modified on display and the Jupyter/browser view is preserved.

  3. Impact (1-2 sentences or a bullet point list):

    • Should not have any operational impact.
  4. Testing Done:

    • This can be tested by:
      • loading charts, then toggling dark/light on the mode bar.
      • Open the chart in a browser to verify the background and text are visible, res.chart.fig
      • Use the method for inverting the theme, res.charting.toggle_chart_style() and then display both ways again.

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels May 9, 2024
@deeleeramone deeleeramone requested a review from hjoaquim May 9, 2024 18:53
@hjoaquim hjoaquim added this pull request to the merge queue May 14, 2024
Merged via the queue into develop with commit 2ac1af3 May 14, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/pywry-plot-paperbg branch May 14, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants