Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] - Case insensitive credentials #6400

Merged
merged 1 commit into from
May 13, 2024

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented May 13, 2024

  1. Why?

    • User might want to specify their key names in uppercase
  2. What?

    • Create uppercase alias in the Credentials model
  3. Impact:

    • Locally ~/.openbb_platform/user_settings.json allows uppercase credential name
    • OpenBB Hub, same as above
  4. Testing Done:

Local test (user_settings.json)

# Set an uppercase key such as BIZTOC_API_KEY -> biztoc_api_key
from openbb import obb
obb.user.credentials.show()

Hub test

# Set an uppercase credential here https://my.openbb.dev/app/platform/credentials
# Such as BIZTOC_API_KEY -> biztoc_api_key
%env OPENBB_HUB_BACKEND=https://payments.openbb.dev
from openbb import obb
obb.account.login(pat="...")
obb.user.credentials.show()

@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels May 13, 2024
@montezdesousa montezdesousa requested a review from piiq May 13, 2024 10:44
@montezdesousa montezdesousa marked this pull request as ready for review May 13, 2024 10:44
@montezdesousa montezdesousa requested a review from IgorWounds May 13, 2024 10:46
@montezdesousa montezdesousa added this pull request to the merge queue May 13, 2024
Merged via the queue into develop with commit 1dd8bf3 May 13, 2024
15 of 20 checks passed
@piiq piiq deleted the bugfix/uppercase-credentials branch May 13, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants